[MCOL-1821] mcsimport not included in tools binary package Created: 2018-10-18  Updated: 2023-10-26  Resolved: 2018-11-10

Status: Closed
Project: MariaDB ColumnStore
Component/s: None
Affects Version/s: 1.2.0
Fix Version/s: 1.2.1

Type: Bug Priority: Major
Reporter: Jens Röwekamp (Inactive) Assignee: Ben Thompson (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Environment:

Linux

Sprint: 2018-19, 2018-20

 Description   

Hi Ben,

could you change the tools buildbot binary packaging step from:
argv: ['sh', '-c', './package.sh', '../build/mariadb-columnstore-tools'] to
argv: ['sh', '-c', './package.sh ../build/mariadb-columnstore-tools']

so that the package.sh argument is in the same quotes as the build path?

Somehow /bin/sh doesn't acknowledge the second parameter otherwise.

This way mcsimport will be included in the binaries.

 Comments   
Comment by Jens Röwekamp (Inactive) [ 2018-10-18 ]

I slightly modified package.sh to only include mcsimport if it was actually build to avoid errors on systems where it isn't build.

For QA:

  • check that the binary package build with buildbot contains mcsimport on Debian 9 and CentOS 7 and Ubuntu 16.04 and that mcsimport is not included in binaries of CentOS 6 and SLES.
Generated at Thu Feb 08 02:31:37 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.