[MCOL-1762] Columnstore.xml new parameters added - autoConfigure needs updating Created: 2018-10-02 Updated: 2023-10-26 Resolved: 2018-10-10 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | ? |
| Affects Version/s: | 1.2 |
| Fix Version/s: | 1.2.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | David Hill (Inactive) | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Sprint: | 2018-18 |
| Description |
|
New parameters added into 1.1. and 1.2 releases, need to be added into autoConfigure.cpp source, which is called during system upgrade installs. Only the parameters need to be added that can be changed by a user. </JobList> </CrossEngineSupport> |
| Comments |
| Comment by David Hall (Inactive) [ 2018-10-04 ] |
|
In addition, we need: This means there are currently two "ThreadPoolSize" to save. There may be more some day. |
| Comment by David Hill (Inactive) [ 2018-10-05 ] |
|
based on Halls comment, I assume "ExeMgr1", "ThreadPoolSize" will need to be done for all ExeMgrs, this is will require more code changes to postConfigure and ProcMgr. When we configure or add UMs, we add new entries into ColumnStore.xml for ExeMgr2, etc... |
| Comment by David Hill (Inactive) [ 2018-10-05 ] |
|
getConfig("ExeMgr1", "ThreadPoolSize") isnt going to be added to the autoConfigure. |
| Comment by David Hill (Inactive) [ 2018-10-05 ] |
|
pull request done https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/580 these 4 entries have been added to the autoConfigure.cpp </JobList> </CrossEngineSupport> |
| Comment by David Hill (Inactive) [ 2018-10-09 ] |
|
also release for 1.1, pull request https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/589 |
| Comment by David Hill (Inactive) [ 2018-10-09 ] |
|
1.1 just need to add </JobList> |
| Comment by Daniel Lee (Inactive) [ 2018-10-10 ] |
|
Builds verified: 1.1 and 1.2 source 1.1.7-1 [dlee@master centos7]$ cat gitInfo.log Merge pull request #132 from mariadb-corporation/release1.1.7 bump version /root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine Merge pull request #589 from mariadb-corporation/ /root/columnstore/mariadb-columnstore-tools Merge pull request #13 from mariadb-corporation/backup/restoreFixes Backup/restore fixes /root/columnstore/mariadb-columnstore-api Merge pull request #116 from mariadb-corporation/ /root/columnstore/mariadb-columnstore-data-adapters Merge pull request #74 from mariadb-corporation/ 1.2.0-1 [dlee@master centos7]$ cat gitInfo.log Merge pull request #134 from mariadb-corporation/versionCmakeFix port changes for mysql_version cmake to fix columnstore RPM packaging /root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine Merge pull request #580 from mariadb-corporation/ /root/columnstore/mariadb-columnstore-tools Merge pull request #10 from mariadb-corporation/develop-merge Develop merge /root/columnstore/mariadb-columnstore-api Merge pull request #117 from mariadb-corporation/upmerge20181008 Upmerge20181008 /root/columnstore/mariadb-columnstore-data-adapters Merge pull request #75 from mariadb-corporation/upmerge20181008 Upmerge20181008 1. Verified that <ThreadPoolSize>100</ThreadPoolSize> is in JobList section of Columnstore.xml for both 1.1 and 1.2 branches. 3) Did a 1.1.7-1 to 1.2.0-1 upgrade and verified the 4 parameters values have migrated over to 1.2.0-1. I manually enter the parameters in the 1.1.7-1's xml file. |