[MCOL-1762] Columnstore.xml new parameters added - autoConfigure needs updating Created: 2018-10-02  Updated: 2023-10-26  Resolved: 2018-10-10

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: 1.2
Fix Version/s: 1.2.0

Type: Bug Priority: Minor
Reporter: David Hill (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2018-18

 Description   

New parameters added into 1.1. and 1.2 releases, need to be added into autoConfigure.cpp source, which is called during system upgrade installs. Only the parameters need to be added that can be changed by a user.

</JobList>
<ThreadPoolSize>100</ThreadPoolSize>

</CrossEngineSupport>
<TLSCA></TLSCA>
<TLSClientCert></TLSClientCert>
<TLSClientKey></TLSClientKey>



 Comments   
Comment by David Hall (Inactive) [ 2018-10-04 ]

In addition, we need:
>getConfig("ExeMgr1", "ThreadPoolSize");

This means there are currently two "ThreadPoolSize" to save. There may be more some day.

Comment by David Hill (Inactive) [ 2018-10-05 ]

based on Halls comment, I assume "ExeMgr1", "ThreadPoolSize" will need to be done for all ExeMgrs, this is will require more code changes to postConfigure and ProcMgr. When we configure or add UMs, we add new entries into ColumnStore.xml for ExeMgr2, etc...

Comment by David Hill (Inactive) [ 2018-10-05 ]

getConfig("ExeMgr1", "ThreadPoolSize") isnt going to be added to the autoConfigure.
If a users adds this, then they need to manually change in the upgrade. That is how we do entries that arent in the default release version..

Comment by David Hill (Inactive) [ 2018-10-05 ]

pull request done

https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/580

these 4 entries have been added to the autoConfigure.cpp

</JobList>
<ThreadPoolSize>100</ThreadPoolSize>

</CrossEngineSupport>
<TLSCA></TLSCA>
<TLSClientCert></TLSClientCert>
<TLSClientKey></TLSClientKey>

Comment by David Hill (Inactive) [ 2018-10-09 ]

also release for 1.1, pull request

https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/589

Comment by David Hill (Inactive) [ 2018-10-09 ]

1.1 just need to add

</JobList>
<ThreadPoolSize>100</ThreadPoolSize>

Comment by Daniel Lee (Inactive) [ 2018-10-10 ]

Builds verified: 1.1 and 1.2 source

1.1.7-1

[dlee@master centos7]$ cat gitInfo.log
/root/columnstore/mariadb-columnstore-server
commit aa1aac4494952204cfe4da086e26263976cd5f1c
Merge: dad0eab bc6fd20
Author: benthompson15 <ben.thompson@mariadb.com>
Date: Mon Sep 10 11:35:57 2018 -0500

Merge pull request #132 from mariadb-corporation/release1.1.7

bump version

/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine
commit 746a738a79c2a92800a9730c1e16533b623ad1e5
Merge: e183557 3b026f4
Author: benthompson15 <ben.thompson@mariadb.com>
Date: Tue Oct 9 17:06:21 2018 -0500

Merge pull request #589 from mariadb-corporation/MCOL-1762-1.1

MCOL-1762 - added joblist ThreadPoolSize

/root/columnstore/mariadb-columnstore-tools
commit 6c8d7b15d33a7e37eb320ce34d727f6c57d17409
Merge: 3333b38 9a58bb9
Author: david hill <david.hill@mariadb.com>
Date: Mon Oct 1 09:33:02 2018 -0500

Merge pull request #13 from mariadb-corporation/backup/restoreFixes

Backup/restore fixes

/root/columnstore/mariadb-columnstore-api
commit ce3364af71f886b916728386af63e86bded27058
Merge: 40661de e94a82e
Author: David Thompson <dthompson@mariadb.com>
Date: Thu Oct 4 22:04:02 2018 -0700

Merge pull request #116 from mariadb-corporation/MCOL-1670

MCOL-1670 - option and logic added to install pymcsapi directly into …

/root/columnstore/mariadb-columnstore-data-adapters
commit d8fdb71a8cdd4e2f3c29c83b1d6d49d23579f3f7
Merge: f5d5f9f 82c0a94
Author: benthompson15 <ben.thompson@mariadb.com>
Date: Tue Oct 9 12:11:53 2018 -0500

Merge pull request #74 from mariadb-corporation/MCOL-1766

MCOL-1766 - PDI gradle dependency resolution timeout increase

1.2.0-1

[dlee@master centos7]$ cat gitInfo.log
/root/columnstore/mariadb-columnstore-server
commit 6b44f0d9c453ede53024f525b7ddf32b5323171b
Merge: 7db44a7 853a0f7
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Thu Sep 27 20:37:03 2018 +0100

Merge pull request #134 from mariadb-corporation/versionCmakeFix

port changes for mysql_version cmake to fix columnstore RPM packaging

/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine
commit 46775f8868ade9a032e5539397e1128c16c4cc22
Merge: ca7cb9a 1ed5fdf
Author: benthompson15 <ben.thompson@mariadb.com>
Date: Tue Oct 9 12:10:19 2018 -0500

Merge pull request #580 from mariadb-corporation/MCOL-1762

MCOL-1762 Keep Columnstore.xml settings

/root/columnstore/mariadb-columnstore-tools
commit 1697bdb16df0321fe3ffefb63fbe85c64b9b5ec9
Merge: 7b310a8 96d5fa7
Author: david hill <david.hill@mariadb.com>
Date: Wed May 2 14:12:35 2018 -0500

Merge pull request #10 from mariadb-corporation/develop-merge

Develop merge

/root/columnstore/mariadb-columnstore-api
commit efb8a65fc54d5e44fa1b8f50d1d92bcff5eaf3ad
Merge: 4ea0cdc 82ed512
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Mon Oct 8 21:28:22 2018 +0100

Merge pull request #117 from mariadb-corporation/upmerge20181008

Upmerge20181008

/root/columnstore/mariadb-columnstore-data-adapters
commit aafc6a0feacc8a06f7f82bb30d1c96b6caab4487
Merge: 6e12dea d15038a
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Mon Oct 8 21:29:11 2018 +0100

Merge pull request #75 from mariadb-corporation/upmerge20181008

Upmerge20181008

1. Verified that <ThreadPoolSize>100</ThreadPoolSize> is in JobList section of Columnstore.xml for both 1.1 and 1.2 branches.
2) Verified the following is in the CrossEngineSupport section for 1.2.
<TLSCA/>
<TLSClientCert/>
<TLSClientKey/>

3) Did a 1.1.7-1 to 1.2.0-1 upgrade and verified the 4 parameters values have migrated over to 1.2.0-1. I manually enter the parameters in the 1.1.7-1's xml file.

Generated at Thu Feb 08 02:31:11 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.