[MCOL-1637] MCOL-1052 causes regression Created: 2018-08-09  Updated: 2019-03-02  Resolved: 2019-03-02

Status: Closed
Project: MariaDB ColumnStore
Component/s: ExeMgr
Affects Version/s: 1.2
Fix Version/s: 1.2.3

Type: Bug Priority: Major
Reporter: David Hall (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Problem/Incident
is caused by MCOL-1052 Implement GROUP BY pushdown support Closed
Sprint: 2018-16, 2018-17, 2018-18, 2018-19, 2018-20, 2018-21, 2019-01, 2019-02

 Description   

Changes for MCOL-1052

in joblistfactory.cpp:1625

void makeVtableModeSteps(CalpontSelectExecutionPlan* csep, JobInfo& jobInfo,
JobStepVector& querySteps, JobStepVector& projectSteps, DeliveredTableMap& deliverySteps)
{
// @bug4848, enhance and unify limit handling.
// if (csep->limitNum() != (uint64_t) - 1) // change: commented out
{

and in jlf_subquery.cpp:754

void addOrderByAndLimit(CalpontSelectExecutionPlan* csep, JobInfo& jobInfo)
{
// make sure there is a LIMIT
// if (csep->orderByCols().size() > 0 && csep->limitNum() == (uint64_t) -1) // Change: commented out
// return;

This causes a regression in working_tpch1/windowFunctions/q0044.sql:

SELECT four, ten/4 as two,
sum(ten/4) over (partition by four order by ten/4 range between unbounded preceding and current row) x,
last_value(ten/4) over (partition by four order by ten/4 range between unbounded preceding and current row) y
FROM (select distinct ten, four from tenk1 order by 1,2) ss order by 1,2,3;

It appears that a limit(1) is inserted by this change into this query.



 Comments   
Comment by David Hall (Inactive) [ 2018-08-09 ]

Commit: 5d48ddb158d33f2ff903a7448315a0c12bc71c2f is where this change occurred

Comment by Roman [ 2018-08-16 ]

Please review the fix.

Comment by Andrew Hutchings (Inactive) [ 2018-11-14 ]

This ticket is marked as "IN TESTING" but has no fixed version. Please update.

Comment by Daniel Lee (Inactive) [ 2019-03-02 ]

Build verified: 1.2.3-1 nightly

server commit:
61f32f2
engine commit:
e849af0

Generated at Thu Feb 08 02:30:14 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.