[MCOL-1630] sendMsgProcMon will return success when module ping fails Created: 2018-08-06  Updated: 2023-10-26  Resolved: 2019-07-10

Status: Closed
Project: MariaDB ColumnStore
Component/s: ?
Affects Version/s: 1.1.5
Fix Version/s: Icebox

Type: Bug Priority: Minor
Reporter: Ben Thompson (Inactive) Assignee: Unassigned
Resolution: Won't Fix Votes: 0
Labels: None


 Description   

sendMsgProcMon receives a string for module id and looks up an ip address from the config file then pings the ip address. If this check of the module fails currently it returns API_SUCCESS

		if ( IPAddr == oam::UnassignedIpAddr ) {
			log.writeLog(__LINE__, "sendMsgProcMon ping failure " + module + " " + IPAddr, LOG_TYPE_ERROR);
			return oam::API_SUCCESS;
		}
	
		string cmdLine = "ping ";
		string cmdOption = " -c 1 -w 5 >> /dev/null";
		string cmd = cmdLine + IPAddr + cmdOption;
		if ( system(cmd.c_str()) != 0) {
			//ping failure
			log.writeLog(__LINE__, "sendMsgProcMon ping failure " + module + " " + IPAddr, LOG_TYPE_ERROR);
			return oam::API_SUCCESS;
		}

Changing this could break in unknown places based on the return success not triggering the immediate failure of a module. So while changing this is simple could require significant testing to verify failures are handled properly


Generated at Thu Feb 08 02:30:11 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.