pleblanc in the world of containers and kubernetes, DNS resolution is back in fashion and so we need the entire columnstore cluster to support operating using hostnames only. In almost all cases if a container is restarted it's going to get a new ip address. We have some hacks in place to support this but it's less than ideal.

I think it's still desirable to support ip addresses as well for bare metal and environments where they don't want to configure DNS.

OK, finished the first cut of the addmodule and postconfig functionality. Tested the success paths & a couple error paths on my local box. It behaves how I think it should, at least as far as I can tell. We can get this into develop once 1.2.2 is finalized for a wider range of testing.

Got swamped after the 1.2.2 release, and next week I'll be unavailable for the review process. I'm sure there will be some back and forth on that. I'll hold off until I can be responsive to change requests. Should be Thursday, Dec 20.

Not sure if you have time for this; if not feel free to reassign.

For QA: Note, the new option to postConfigure is '-x' not '-d'. -d is already taken.

Without the -x, it would turn a hostname into an ip addr and store that.

Daniel found a couple problems in 1.2.3rc on centos 7
1) if you use postconfig without -x, it doesn't take hostnames at all.
2) if you do use -x, it stores the hostname, but when you run postconfig again, it doesn't think it's on PM1 anymore.

For #1 above, it looks like that was a pre-existing inconsistency in the path Daniel went down. Fixed that. Also fixed a prompt that asked for IP addresses only, when it also would take hostnames.

For #2, the existing 'am I PM 1?' check looks at ip addresses, I made postconfig resolve hostname -> IP before that.

Will issue the PR in a few mins.

Build tested: 1.2.3-1

[dlee@master centos7]$ cat gitversionInfo.txt
server commit:
61f32f2
engine commit:
e849af0

Finally finish testing this ticket. I performed:

1) functional tests on installation, addmodule and removemodule
2) system shutdown and restart
3) installations with and without the -x option
4) all support operating system
5) few multiple-module confections.

Overall, it is working as design. I just found a minor issue for the OAM getSystemNetworkConfig command. For the right most columns, the column heading is "IP address", but the column values are host names. Since we already have the "Host Name" columnstore, we should get the IP addresses at the time when command is executed and display them accordingly. It should be a quick change.

mcsadmin> getsystemnetworkconfig
getsystemnetworkconfig Wed Feb 27 22:26:19 2019

System Network Configuration

Module Name Module Description NIC ID Host Name IP Address
----------- ------------------------- ------ --------- ---------------
um1 User Module #1 1 s1um1 s1um1
pm1 Performance Module #1 1 s1pm1 s1pm1
pm2 Performance Module #2 1 s1pm2 s1pm2

Reopening the ticket per the getSystemNetworkConfig issue.

Made it resolve the ip addr for printing that field. Assigned the PR to Andrew.

Build verified: 1.2.3-1 nightly
server commit:
61f32f2
engine commit:
fddd108

Verified latest change. Also rechecked the requested implementation.