[MCOL-1545] Compiler error in GCC 8.1 Created: 2018-07-09  Updated: 2018-07-25  Resolved: 2018-07-25

Status: Closed
Project: MariaDB ColumnStore
Component/s: None
Affects Version/s: None
Fix Version/s: 1.1.6

Type: Bug Priority: Minor
Reporter: Andrew Hutchings (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2018-14, 2018-15

 Description   

This won't affect us now, but will affect us in future:

/home/fedora/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/joiner/../common/simpleallocator.h: In member function ‘utils::SimplePool* utils::SimpleAllocator<T>::getPool()’:
 
/home/fedora/Git/mariadb-columnstore-server/mariadb-columnstore-engine/utils/joiner/../common/simpleallocator.h:122:33: error: cannot convert ‘boost::shared_ptr<utils::SimplePool>’ to ‘utils::SimplePool*’ in return
 
  SimplePool* getPool() { return fPool; }

We need to check whether or not this should return the shared_ptr instead. If not then use .get() on the end of fPool.

There are also quite a few warnings that could help with optimization in that release.

 Comments   
Comment by Andrew Hutchings (Inactive) [ 2018-07-19 ]

For QA: everything should still compile. An unused internal function is removed.

Comment by Daniel Lee (Inactive) [ 2018-07-25 ]

Build verified: 1.1.6-1 source

/root/columnstore/mariadb-columnstore-server
commit 513775738f72ec990d055a5d47e2511e3c0e34dd
Merge: 3c37210 9236098
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Wed Jul 18 09:37:17 2018 +0100

Merge pull request #123 from drrtuy/MCOL-970

MCOL-970 Slow query log now contains original query even in vtable mode

/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine
commit f9f6dc43dd15ad3f2ca2d9e515b1e44028a16183
Merge: ced7eb4 1170b4e
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Tue Jul 24 18:06:24 2018 +0100

Merge pull request #526 from mariadb-corporation/MCOL-1535

Mcol 1535

Build successful. There errors not longer being outputted.

Generated at Thu Feb 08 02:29:33 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.