[MCOL-1495] Memory leak in WriteEngineServ Created: 2018-06-22 Updated: 2019-07-09 Resolved: 2019-05-10 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | writeengine |
| Affects Version/s: | None |
| Fix Version/s: | 1.2.4 |
| Type: | Bug | Priority: | Major |
| Reporter: | Andrew Hutchings (Inactive) | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Sprint: | 2019-05 | ||||||||||||||||
| Description |
|
There have been a few reports of memory leaks in WriteEngineServ that needs to be investigated. We require valgrind to work properly first ( |
| Comments |
| Comment by Andrew Hutchings (Inactive) [ 2018-07-02 ] |
|
Spent a little time investigating this last week with a few small cases and haven't reproduced it yet. |
| Comment by Andrew Hutchings (Inactive) [ 2018-12-10 ] |
|
This is likely to be solved by the ThreadPool leak fixes. |
| Comment by Roman [ 2019-04-30 ] |
|
I will open this one b/c WriteEngine leaks even with jemalloc and ThreadPool fixes. |
| Comment by Roman [ 2019-05-07 ] |
|
Please review the fix. |
| Comment by Roman [ 2019-05-07 ] |
|
For QA. You could monitor the memory leak with top. It is easy to see the difference b/w memory consumption in the beggining and after 300 mixed DML operations: insert, update, delete. |
| Comment by Daniel Lee (Inactive) [ 2019-05-10 ] |
|
Build verified: 1.2.4-1 nightly Executed Autopilot's concurrentDML test on both 1.2.3-1 and 1.2.4-1. Write engine on 1.2.4-1 used 1/4 of the memory 1.2.3-1 used, 4.5% instead 18.2%. server commit: 1.2.3-1 Before test top - 17:39:37 up 1 min, 1 user, load average: 0.39, 0.20, 0.07 PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND After test top - 20:54:25 up 3:16, 1 user, load average: 1.54, 2.54, 2.42 PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 1.2.4-1 top - 17:36:52 up 1 min, 1 user, load average: 0.31, 0.17, 0.06 PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND After test top - 12:57:04 up 19:21, 1 user, load average: 0.16, 0.05, 0.06 PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND |
| Comment by Playax [ 2019-05-17 ] |
|
Will this fix be available on version 1.1.8? |
| Comment by Roman [ 2019-05-20 ] |
|
Yes, we plan to add this fix into 1.1 |
| Comment by Playax [ 2019-07-09 ] |
|
Any forecast about when this will be released on 1.1? I don't see it on this page: |
| Comment by Roman [ 2019-07-09 ] |
|
It's already backported in 1.1 branch so 1.1.8 contains the fix. |