[MCOL-1406] Cannot create pv_facts table in develop Created: 2018-05-11  Updated: 2018-05-30  Resolved: 2018-05-30

Status: Closed
Project: MariaDB ColumnStore
Component/s: None
Affects Version/s: 1.2.0
Fix Version/s: 1.1.5

Type: Bug Priority: Major
Reporter: Andrew Hutchings (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2018-10, 2018-11

 Description   

The following works fine in 1.1 but errors in develop:

CREATE TABLE `pv_facts` (
 
  `page_view_id` varchar(35) NOT NULL,
 
  `visit_date_key` date NOT NULL,
 
  `visit_time_key` varchar(6) DEFAULT "000000",
 
  `visitor_key` int unsigned NOT NULL,
 
  `user_key` int unsigned NOT NULL,
 
  `referring_url_key` int unsigned NOT NULL,
 
  `url_key` int unsigned NOT NULL,
 
  `publication_key` int unsigned NOT NULL,
 
  `eref_key` int unsigned NOT NULL,
 
  `iref_key` int unsigned NOT NULL,
 
  `content_key` int unsigned NOT NULL,
 
  `device_key` int unsigned NOT NULL,
 
  `visit_time` decimal(18,5) NOT NULL,
 
  `visit_id` varchar(100) NOT NULL,
 
  `ip_address` bigint NOT NULL,
 
  `visit_type` varchar(20) NOT NULL,
 
  `page_type` varchar(20) NOT NULL,
 
  `page_id` varchar(255) DEFAULT NULL,
 
  `first_byte` int unsigned DEFAULT NULL,
 
  `dom_interactive` int unsigned DEFAULT NULL,
 
  `dns_lookup` int unsigned DEFAULT NULL,
 
  `dom_done` int unsigned DEFAULT NULL,
 
  `small_screen` int unsigned DEFAULT "0",
 
  `view_width` int unsigned DEFAULT "0",
 
  `view_height` int unsigned DEFAULT "0"
 
) ENGINE=Columnstore DEFAULT CHARSET=utf8;



 Comments   
Comment by Roman [ 2018-05-15 ]

Please review.

Comment by Roman [ 2018-05-15 ]

I have concerns about the issue, since packaged and built server's behavior are different. I will research it a little bit, however the fix is ready and pushed up.

Comment by Andrew Hutchings (Inactive) [ 2018-05-18 ]

Kicking this back so it can be implemented for 1.1 instead

Comment by Roman [ 2018-05-23 ]

Please review.

Comment by Daniel Lee (Inactive) [ 2018-05-30 ]

Build verified: 1.1.5-1 source

/root/columnstore/mariadb-columnstore-server
commit 0c983bff02172849a174dde46b62d76aa66485f8
Merge: 6b8a674 d5e6d89
Author: benthompson15 <ben.thompson@mariadb.com>
Date: Thu Apr 26 16:16:51 2018 -0500

Merge pull request #112 from mariadb-corporation/davidhilldallas-patch-3

update to 1.1.5

/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine
commit 3f466541fc5107ad95f9d48de3d305b049873f2e
Merge: 1ea5198 04c87ac
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Tue May 29 22:04:40 2018 +0100

Merge pull request #480 from drrtuy/MCOL-1406_1_1

MCOL-1406 DEFAULT value in double quotes for develop-1.1

Verified fixed in 1.1.5-1 source.

1.2.0-1 regression test000 test still failing due to this issue. My understanding is that 1.x has not been merged into 1.2 yet. Will test for 1.2 again after merging.

Generated at Thu Feb 08 02:28:31 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.