[MCOL-1386] Create table statement doesn't allow usage of C style comments in it Created: 2018-05-04  Updated: 2018-05-30  Resolved: 2018-05-30

Status: Closed
Project: MariaDB ColumnStore
Component/s: None
Affects Version/s: 1.1.3
Fix Version/s: 1.2.0

Type: Bug Priority: Minor
Reporter: Elena Kotsinova (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2018-10, 2018-11

 Description   

Query:

CREATE TABLE f_supp
 
(
 
i TINYINT NOT NULL
 
/*,b INT NOT NULL
 
,c CHAR(1) NOT NULL */
 
) ENGINE=ColumnStore;

returns error:

Error Code: 1178. The storage engine for the table doesn't support The syntax or the data type(s) is not supported by Columnstore. Please check the Columnstore syntax guide for supported syntax or data types.

Expected:
This is allowed syntax. It is expected multi line comments to be recognized as such.

 Comments   
Comment by Roman [ 2018-05-10 ]

Please review.

Comment by Roman [ 2018-05-10 ]

I tried to implement nested c-style comments, but the feature is blocked by the server lexer. Will try to push nested comments feature into the server later.

Comment by Roman [ 2018-05-11 ]

Talking about the feature inclusion I meant upstream server code, since it is handy to have nested comments.

Comment by Daniel Lee (Inactive) [ 2018-05-30 ]

Build verified: 1.2.0-1 source

/root/columnstore/mariadb-columnstore-server
commit 4334641df0df040e0f53332c11dc8e29dc34b8b7
Merge: 960853c cd5e845
Author: David.Hall <david.hall@mariadb.com>
Date: Mon Apr 9 13:23:44 2018 -0500

Merge pull request #107 from mariadb-corporation/dev-merge-up-20180409

Dev merge up 20180409

/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine
commit e79daac8a9b1c8047aeabc3d73ae137cc151f84e
Merge: 8790177 8a3c5e0
Author: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Tue May 15 15:34:19 2018 +0100

Merge pull request #472 from drrtuy/MCOL-1073

MCOL-1073 Removed DecomSrv

I could not reproduce the issue in release 1.1.3-1.

Executed the create table in the work bug description and it worked on both 1.1.3-1 and 1.2.0-1.

Generated at Thu Feb 08 02:28:21 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.