[MCOL-1384] Couldn't use reserved words in idents even with quotes(backport from develop) Created: 2018-05-04 Updated: 2018-07-06 Resolved: 2018-06-06 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | ExeMgr |
| Affects Version/s: | None |
| Fix Version/s: | 1.1.5 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Roman | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Sprint: | 2018-10, 2018-11, 2018-12 | ||||||||
| Description |
|
Steps to reproduce CREATE TABLE `table` create table kvstore( `key` varchar(1024), `value` varchar(1024) ) engine=columnstore; |
| Comments |
| Comment by Roman [ 2018-05-04 ] | ||||||||||||
|
Backport the feature from the issue. | ||||||||||||
| Comment by Roman [ 2018-05-07 ] | ||||||||||||
|
Please review. I will come regression tests later. | ||||||||||||
| Comment by Daniel Lee (Inactive) [ 2018-05-22 ] | ||||||||||||
|
Build verified: 1.1.5-1 source [root@localhost ~]# cat mariadb-columnstore-1.1.5-1-centos7.x86_64.bin.tar.gz.txt Merge pull request #112 from mariadb-corporation/davidhilldallas-patch-3 update to 1.1.5 /root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine Merge pull request #475 from drrtuy/ Could not reproduced the issue in 1.1.4-1. Verified that it works in 1.1.5-1. Welcome to the MariaDB monitor. Commands end with ; or \g. Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others. Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. MariaDB [tpch1]> create database cs; MariaDB [tpch1]> use cs; MariaDB [cs]> desc cs1;
------
------ | ||||||||||||
| Comment by Daniel Lee (Inactive) [ 2018-05-23 ] | ||||||||||||
|
MariaDB [mytest]> create database cs; MariaDB [mytest]> create table `cs`.`insert`(i bigint) engine=columnstore; MariaDB [mytest]> create table cs.update(i bigint) engine=columnstore; MariaDB [mytest]> insert into cs.insert values (1); MariaDB [mytest]> select * from cs.insert;
------
------ MariaDB [mytest]> update cs.insert set i=5; MariaDB [mytest]> select * from cs.insert;
------
------ MariaDB [mytest]> delete from cs.insert; MariaDB [mytest]> truncate table cs.insert; MariaDB [mytest]> drop table cs.insert; | ||||||||||||
| Comment by Daniel Lee (Inactive) [ 2018-05-25 ] | ||||||||||||
|
Build tested: 1.1.5-1 source /root/columnstore/mariadb-columnstore-server Merge pull request #112 from mariadb-corporation/davidhilldallas-patch-3 update to 1.1.5 /root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine Merge pull request #475 from drrtuy/ Developer provided additional test case. The original provided test case did not test the issue sufficiently. Reproduced the reported issues in 1.1.4-1 In 1.1.5-1, these two statements worked: MariaDB [mytest]> set session sql_mode=ANSI_QUOTES; MariaDB [mytest]> create table `cs`. `SELECTe`(`key` bigint) engine=columnstore; MariaDB [mytest]> create table "cs". "SELECTf"("key" bigint) engine=columnstore; but the following statement hung and never returned: create table cs.`somea`(`key` bigint) engine=columnstore; I restarted ColumnStore and tried the create statement again and got: MariaDB [mytest]> create table cs.`somea`(`key` bigint) engine=columnstore; I tried to drop the table and it also hung: MariaDB [mytest]> drop table cs.`somea`; | ||||||||||||
| Comment by Roman [ 2018-05-26 ] | ||||||||||||
|
Not fixed yet. | ||||||||||||
| Comment by Daniel Lee (Inactive) [ 2018-06-04 ] | ||||||||||||
|
Build tested: 1.1.5-1 source /root/columnstore/mariadb-columnstore-server Merge pull request #118 from mariadb-corporation/ Merge MariaDB 10.2.15 into develop-1.1 /root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine Merge pull request #485 from drrtuy/ The reported hanging issue has been fixed, but the following create statement that was working, now no longer works. MariaDB [mytest]> create table "cs". "SELECTf"("key" bigint) engine=columnstore; The 2nd one has the space between the schema name and table name removed. It seems that double quote is no longer supported. | ||||||||||||
| Comment by Daniel Lee (Inactive) [ 2018-06-04 ] | ||||||||||||
|
reopened per my last comment | ||||||||||||
| Comment by Andrew Hutchings (Inactive) [ 2018-06-06 ] | ||||||||||||
|
Your CREATE TABLE statement isn't valid for MariaDB, this is not a regression. This is regular MariaDB:
| ||||||||||||
| Comment by Daniel Lee (Inactive) [ 2018-06-06 ] | ||||||||||||
|
Since the statement with double is not supposed by the MariaDB server, it is a non-issue. |