[MCOL-1222] ColumnStore start/restart can return before system is ready Created: 2018-02-20  Updated: 2018-03-23  Resolved: 2018-03-23

Status: Closed
Project: MariaDB ColumnStore
Component/s: None
Affects Version/s: 1.1.3
Fix Version/s: 1.1.4

Type: Bug Priority: Minor
Reporter: Andrew Hutchings (Inactive) Assignee: Daniel Lee (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Sprint: 2018-06

 Description   

As observed in the regression suite it is possible for mcsadmin (and maybe postConfigure) to return before ColumnStore is ready to accept queries. We probably shouldn't do this.



 Comments   
Comment by David Hall (Inactive) [ 2018-02-20 ]

We should modify waitForActive() in mcsadmin to look at DBRM::getSystemQueryReady()

Comment by David Hill (Inactive) [ 2018-03-15 ]

fixed... moved the waitForActive() from postConfigure and mcsadmin to oam APIs. added check for DBRM::getSystemQueryReady().

pull request

https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/428

Comment by David Hill (Inactive) [ 2018-03-15 ]

pull request

https://github.com/mariadb-corporation/mariadb-columnstore-engine/pull/428

Comment by David Hill (Inactive) [ 2018-03-15 ]

how to test...

1. postConfigure install and make sure system goes active and good return back to user
2. mcsadmin restartsystem and startsystem and make sure system goes active and returns success back to user.

Comment by David Hall (Inactive) [ 2018-03-21 ]

The new wait period of 10 seconds in a loop is excessive. The previous wait of 3 seconds in a loop is much less annoying to a user.

Comment by David Hill (Inactive) [ 2018-03-22 ]

changing design to sleep for 3 seconds instead of 10 and print the dot to the screen every 9 seconds. this will keep the dots from rapping around on on startups, like multi-node systems.

Comment by Daniel Lee (Inactive) [ 2018-03-23 ]

Build tested: 1.1.4-1 source

/root/columnstore/mariadb-columnstore-server
commit 3b5242143b394423dbdf96d888410a3c33f9ff97
Merge: b7d93b7 23900e6
Author: benthompson15 <ben.thompson@mariadb.com>
Date: Wed Mar 7 10:39:40 2018 -0600
Merge pull request #104 from mariadb-corporation/davidhilldallas-patch-3
update version
/root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine
commit 4e167285c6665c9aa0e204eac2de0add61709be4
Merge: 819c69c b800fc7
Author: benthompson15 <ben.thompson@mariadb.com>
Date: Wed Mar 14 13:25:21 2018 -0500
Merge pull request #427 from mariadb-corporation/MCOL-1225
Mcol 1225 - fix mysql/lib library path
[root@localhost mariadb-columnstore-api]# git show
commit 8f4f304e22c8629e6b5feb0bb9724b09ae89b787
Merge: acf32cc a2ec28a
Author: sneJ p <sneJ-@users.noreply.github.com>
Date: Thu Mar 22 00:59:01 2018 -0700
Merge pull request #61 from mariadb-corporation/1.1-mergeup-20180322
Merge develop-1.1 into develop

regression tested binary installation, restart system, shutdown and start system on a 1um2pm stack.

Comment by Daniel Lee (Inactive) [ 2018-03-23 ]

Also tested concurrent queries right after system became available.

Generated at Thu Feb 08 02:27:07 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.