[MCOL-1168] SystemCatalog Test fails Created: 2018-01-16 Updated: 2023-10-26 Resolved: 2018-01-18 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | None |
| Affects Version/s: | 1.1.3 |
| Fix Version/s: | 1.1.3 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Jens Röwekamp (Inactive) | Assignee: | Jens Röwekamp (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Sprint: | 2018-02 |
| Description |
|
After adding line 151 in src/mcsapi_types_impl.h in commit 7c074ccfad6e2d75bfb4bb86e1d0af0fe68f935e ( |
| Comments |
| Comment by Andrew Hutchings (Inactive) [ 2018-01-16 ] |
|
what platform was this on? |
| Comment by Jens Röwekamp (Inactive) [ 2018-01-17 ] |
|
Reproduced on Ubuntu 16.04 and Debian9. Haven't tested any other OSes. |
| Comment by Andrew Hutchings (Inactive) [ 2018-01-18 ] |
|
OK, reproduced this, not sure why I didn't spot it earlier. Basically when you get an item off the system catalogue in the API it returns a reference. When that reference goes out of scope the destructor is called which destroys some of the internal pointers inside the internal copy of the system catalogue. Final destruction causes a double-free. Trying to work on a fix that won't break the API compatibility... |
| Comment by Andrew Hutchings (Inactive) [ 2018-01-18 ] |
|
With patch the test now passes and valgrind shows the leak has gone |
| Comment by Jens Röwekamp (Inactive) [ 2018-01-18 ] |
|
Tested on Ubuntu 16.04, all 23 tests passed. Checked with valgrind for memory leaks ( |