[MCOL-1052] Implement GROUP BY pushdown support Created: 2017-11-27 Updated: 2018-09-17 Resolved: 2018-05-31 |
|
| Status: | Closed |
| Project: | MariaDB ColumnStore |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.2.0 |
| Type: | New Feature | Priority: | Major |
| Reporter: | Andrew Hutchings (Inactive) | Assignee: | Daniel Lee (Inactive) |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Epic Link: | MariaDB ColumnStore Generic Engine phase 1 | ||||||||||||||||||||||||||||||||
| Sprint: | 2018-07, 2018-08, 2018-09, 2018-10, 2018-11 | ||||||||||||||||||||||||||||||||
| Description |
|
MariaDB has a group_by_handler with example code to push down the group by condition. This is required to help us become a generic engine. |
| Comments |
| Comment by Roman [ 2018-05-03 ] |
|
Please review this. |
| Comment by Andrew Hutchings (Inactive) [ 2018-05-05 ] |
|
Great work! I think at a later date we should maybe look at breaking out the larger code segments from places like ha_calpont_execplan.cpp into separate files. But that is more of a cleanup task. Very happy to see this! |
| Comment by Andrew Hutchings (Inactive) [ 2018-05-05 ] |
|
For QA: This basically pushes down GROUP BY queries into ColumnStore when vtable mode is disabled. Whilst this is only slightly useful now (much better performance when vtable is off) it will be very useful when we get to a point where we can get rid of vtable. There is a new set of regression tests called "test022" which covers this. |
| Comment by Daniel Lee (Inactive) [ 2018-05-30 ] |
|
/root/columnstore/mariadb-columnstore-server Merge pull request #107 from mariadb-corporation/dev-merge-up-20180409 Dev merge up 20180409 /root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine Merge pull request #472 from drrtuy/ ssd=31.250 1.1.3-1 10g dbt3 select l_shipmode from lineitem where l_shipmode='AIR' group by l_shipmode,l_receiptdate; 1.2.0-1 10g dbt3 select l_shipmode from lineitem where l_shipmode='AIR' group by l_shipmode,l_receiptdate; Attempted running regression test022 and it is not yet working. Possibly code is not yet merged. Will try regression test later. |
| Comment by Daniel Lee (Inactive) [ 2018-05-31 ] |
|
Build verified: 1.2.0-1 source /root/columnstore/mariadb-columnstore-server Merge pull request #119 from mariadb-corporation/1.1-merge-up-20180531 Merge develop-1.1 into develop /root/columnstore/mariadb-columnstore-server/mariadb-columnstore-engine Merge pull request #486 from drrtuy/ MCOL 1449 Fix the regression in sorting orientation. There is an issue with regression test022 due to unrelated issue. Close this ticket since the fix is working. Will check for regression in future builds. |