[CONCPP-71] SQLString destructor shouldn't be virtual Created: 2021-02-23 Updated: 2021-03-11 Resolved: 2021-03-11 |
|
| Status: | Closed |
| Project: | MariaDB Connector/C++ |
| Component/s: | General |
| Affects Version/s: | 0.9.4 |
| Fix Version/s: | 1.0.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Lawrin Novitsky | Assignee: | Lawrin Novitsky |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The class isn't supposed to be inherited, it's even explicitly declared as 'final'. There is absolutely no need to have it virtual - that only makes object size larger, as it's the only virtual method. |