[CONC-625] Client error code 2059 is listed twice in ma_errmsg.c Created: 2023-01-12  Updated: 2023-01-15  Resolved: 2023-01-15

Status: Closed
Project: MariaDB Connector/C
Component/s: Error handling
Affects Version/s: 3.1.19, 3.3.3
Fix Version/s: 3.3.4, 3.1.20

Type: Bug Priority: Trivial
Reporter: Geoff Montee (Inactive) Assignee: Georg Richter
Resolution: Fixed Votes: 0
Labels: None


 Description   

MariaDB Connector/C lists client error code 2059 twice in ma_errmsg.c

/* 2059 */  "Can't connect twice. Already connected",
/* 2058 */  "Plugin %s could not be loaded: %s",
/* 2059 */  "An attribute with same name already exists",

https://github.com/mariadb-corporation/mariadb-connector-c/blob/v3.3.3/libmariadb/ma_errmsg.c#L88

https://github.com/mariadb-corporation/mariadb-connector-c/blob/v3.2.7/libmariadb/ma_errmsg.c#L88

https://github.com/mariadb-corporation/mariadb-connector-c/blob/v3.1.19/libmariadb/ma_errmsg.c#L143



 Comments   
Comment by Wayne Davison (Inactive) [ 2023-01-12 ]

Since the numbers are just comments, I'm assuming that the actual numbers auto-increment by 1 for every string found in the list. As such, my script outputs these warnings:

Expected 2058 but got 2059 for error: Can't connect twice. Already connected
Expected 2059 but got 2058 for error: Plugin %s could not be loaded: %s
Expected 2060 but got 2059 for error: An attribute with same name already exists
Expected 2061 but got 2060 for error: Plugin doesn't support this function

... and those errors are assigned the "expected" number, not the comment number.

Generated at Thu Feb 08 03:06:39 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.