[CONC-498] mysql.h missing #include "mysql_version.h" Created: 2020-09-12  Updated: 2020-09-14  Resolved: 2020-09-14

Status: Closed
Project: MariaDB Connector/C
Component/s: None
Affects Version/s: 3.1.9
Fix Version/s: 3.1.10

Type: Bug Priority: Major
Reporter: Daniel Black Assignee: Georg Richter
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-23732 Build fails with lastest C/C 3.1 Confirmed

 Description   

comparison of mysql_version.h includes

$ grep -r  'mysql_version\.h'      /usr/local/m*/include/
/usr/local/mariadb-10.5.6/include/mysql/server/mysql.h:#include "mysql_version.h"
/usr/local/mariadb-10.5.6/include/mysql/server/private/unireg.h:#include <mysql_version.h>                      /* FRM_VER */
/usr/local/mariadb-10.5.6/include/mysql/server/private/sql_const.h:#include <mysql_version.h>
/usr/local/mysql-5.6.49-linux-glibc2.12-x86_64/include/mysql.h:#include "mysql_version.h"
/usr/local/mysql-5.7.31-linux-glibc2.12-x86_64/include/mysql/plugin.h:#include "mysql_version.h" /* MYSQL_VERSION_ID */
/usr/local/mysql-5.7.31-linux-glibc2.12-x86_64/include/mysql.h:#include "mysql_version.h"
/usr/local/mysql-5.7.31-linux-glibc2.12-x86_64/include/plugin.h:#include "mysql_version.h" /* MYSQL_VERSION_ID */
/usr/local/mysql-8.0.21-linux-glibc2.12-x86_64/include/mysql.h:#include "mysql_version.h"  // IWYU pragma: keep

Without it defines ike MYSQL_UNIX_ADDR aren't exposed tot he client as per the php-7.3 compile error:

php-7.3 version=mariadb-10.5.6; ../php-src/configure --enable-debug --with-mysqli=/usr/local/$version/bin/mysql_config --with-pdo-mysql=/usr/local/$version

 
/home/dan/repos/php-src/ext/mysqli/mysqli.c: In function ‘zm_info_mysqli’:
/home/dan/repos/php-src/ext/mysqli/mysqli.c:972:47: error: ‘MYSQL_UNIX_ADDR’ undeclared (first use in this function); did you mean ‘PDO_MYSQL_UNIX_ADDR’?
  972 |  php_info_print_table_row(2, "MYSQLI_SOCKET", MYSQL_UNIX_ADDR);
      |                                               ^~~~~~~~~~~~~~~
      |                                               PDO_MYSQL_UNIX_ADDR
/home/dan/repos/php-src/ext/mysqli/mysqli.c:972:47: note: each undeclared identifier is reported only once for each function it appears in



 Comments   
Comment by Daniel Black [ 2020-09-14 ]

Thanks https://github.com/mariadb-corporation/mariadb-connector-c/commit/fb4e99fc7ef1e36d8a15b2f7142704c011056a03

Generated at Thu Feb 08 03:05:45 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.