[CONC-381] Warning with strict prototypes enabled Created: 2018-12-20  Updated: 2020-07-08  Resolved: 2020-07-08

Status: Closed
Project: MariaDB Connector/C
Component/s: None
Affects Version/s: 3.0.7
Fix Version/s: 3.1.10

Type: Bug Priority: Minor
Reporter: Evan Miller Assignee: Georg Richter
Resolution: Fixed Votes: 1
Labels: None
Environment:

Apple LLVM version 10.0.0 (clang-1000.10.44.4)



 Description   

If -Wstrict-prototypes are enabled when compiling a project that links against MariaDB Connector/C 3.0.7, the following warning appears:

{{/usr/include/mariadb/mysql.h:440:3: warning: this function declaration is not a prototype [-Wstrict-proto
types]
MYSQL_CLIENT_PLUGIN_HEADER
^
/usr/include/mariadb/mysql.h:436:16: note: expanded from macro 'MYSQL_CLIENT_PLUGIN_HEADER'
int (*deinit)(); \
^
1 warning generated.}}

Changing the line to int (*deinit)(void); will fix the issue.



 Comments   
Comment by Evan Miller [ 2020-07-07 ]

This issue is still present in version 3.1.9. It is a very easy fix. I am happy to submit a pull request.

Comment by Evan Miller [ 2020-07-07 ]

Pull request submitted: https://github.com/mariadb-corporation/mariadb-connector-c/pull/141

Generated at Thu Feb 08 03:04:54 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.