[CONC-288] Renaming the "rest" macro in ma_list.h and my_list.h to "list_rest" Created: 2017-10-19 Updated: 2017-10-19 Resolved: 2017-10-19 |
|
| Status: | Closed |
| Project: | MariaDB Connector/C |
| Component/s: | None |
| Affects Version/s: | 3.0.2 |
| Fix Version/s: | 3.0.3 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Petar Ivanov | Assignee: | Georg Richter |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | 10.2-ga, Compatibility, regression | ||
| Environment: |
RedHat 7.3 with MariaDB-devel-10.2.9-1.el7.centos.x86_64 package from the MariaDB yum repository |
||
| Description |
|
Hi All, I've been migrating a cross-platform C++ code-base (Intel/SPARC, Solaris/RedHat/Ubuntu) from MySQL to MariaDB. Problem I faced is that ma_list.h file (included by mysql.h) has a macro named rest (we don't use it). Issue for us is that this is a very common word and in our case it clashes with boost::spirit headers. Workaround for us is to just #undef rest after including mysql.h . I checked in MySQL connector as well as the MariaDB connector on Solaris Intel (10.1.22-MariaDB tarball) and the macro there is named list_rest . Looking at other list macros, they are all named list_ . Could you please consider renaming it back to list_rest to maintain MySQL compatibility? BR, |
| Comments |
| Comment by Georg Richter [ 2017-10-19 ] |
|
Fixed in master branch |
| Comment by Petar Ivanov [ 2017-10-19 ] |
|
Thanks! |