MySQL BUG#12735829 - SPACE() FUNCTION WARNING REFERS TO REPEAT() IN ER_WARN_ALLOWED_PACKET_OVERFLOWED

revno: 3402.2.8

committer: Raghav Kapoor <raghav.kapoor@oracle.com>

branch nick: mysql-bug-12735829v2

timestamp: Thu 2011-09-22 16:12:10 +0530

message:

  BUG#12735829 - SPACE() FUNCTION WARNING REFERS TO REPEAT()

  IN ER_WARN_ALLOWED_PACKET_OVERFLOWED

  BACKGROUND:

  Previously in the bug,the warning text was incorrect.Instead

  of printing space it was printing repeat in the warning message.

  FIX:

  The bug has been fixed by creating a new class Item_func_space

  in item_strfunc.h file and implementing fix_length_and_dec()

  and val_str(String *str) functions for it in item_strfunc.cc.

  Also Create_func_space now returns Item_func_space in

  item_create.cc file.This patch also partially fixes the

  bug#11746123 which arises because of wrong implementaion of

  space() function which "caches" session character set and

  collation at creation time.Test cases have been written to

  demonstrate the fix for the both the bugs in func_str.test

  file and the corrsponding result files have also been updated.