MySQL Bug #31293 create logfile group/tablespace returns OK with warning when engine=myisam

revno: 2876.159.4

committer: Jon Olav Hauglid <jon.hauglid@sun.com>

branch nick: mysql-next-mr-bugfixing-bug31110

timestamp: Mon 2010-03-15 15:50:52 +0100

message:

  Backport of:

      ------------------------------------------------------------

      revno: 2617.31.30

      committer: Jon Olav Hauglid <jon.hauglid@sun.com>

      branch nick: mysql-6.0-runtime-bugged

      timestamp: Fri 2009-05-08 15:34:08 +0200

      message:

        Bug #31293 create logfile group/tablespace returns OK with warning

        when engine=myisam

        Bug title slightly misleading. The problem was that syntax

        errors (1064) were mistakenly generated for the following statements:

        CREATE TABLESPACE

        ALTER TABLESPACE

        DROP TABLESPACE

        CREATE LOGFILE GROUP

        ALTER LOGFILE GROUP

        DROP LOGFILE GROUP

        These statments used without any extra clauses gave syntax errors.

        Adding one or more clauses would remove the syntax error, even if

        those clauses are all defined as optional. The fix changes the

        grammar to accept statements without extra clauses so that the

        above statments give the proper error message used with engine=myisam:

        ERROR 1478 (HY000): Table storage engine 'MyISAM' does not support the

        create option 'TABLESPACE or LOGFILE GROUP'

        Note that the ENGINE clause was optional before this fix even if this

        does not match the current version of the reference manual where it

        is marked as required. The manual should therefore be updated marking

        the ENGINE clause as optional for all statements listed above.

        Parser.test appended with a test of various statements that should

        give error 1478 ER_ILLEGAL_HA_CREATE_OPTION, but before gave syntax error.