Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24213

mariadb-upgrade ignores setgid bit on datadir

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Not a Bug
    • 10.5.7
    • N/A
    • Scripts & Clients, Upgrades
    • None
    • Fedora release 31

    Description

      When the setgid bit is set on a directory, all the files created inside it should get the group of that directory.

      The MariaDB server itself appears to observe this rule.

      However, the mariadb-upgrade utility does not. With datadir=/var/lib/mariadb:

      chgrp root /var/lib/mariadb
      chmod u=rwx,g=rwxs,o= /var/lib/mariadb
      chmod -R g=rwX /var/lib/mariadb/*
       
      # Observe that group of an example file in datadir's mysql folder is 'root':
      ls -l /var/lib/mariadb/mysql/time_zone.frm
       
      # Run mariadb-upgrade:
      mariadb-upgrade --force -u root -p
       
      # Observe that the group of the example file in datadir's mysql folder has changed to 'mysql':
      ls -l /var/lib/mariadb/mysql/time_zone.frm
      

      I think the mariadb-upgrade tool should follow the normal convention regarding the setgid bit on directories.

      Note that if the setgid bit is set on the actual datadir's mysql folder, then mariadb-upgrade seems to behave as expected.

      Attachments

        Activity

          People

            Unassigned Unassigned
            karll Karl Levik
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.