Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24167

InnoDB unnecessarily uses complex rw-lock implementation

    XMLWordPrintable

Details

    Description

      InnoDB implements its own complex rw-latch whose special features (recursive X-locks and SX-locks) are only needed for buf_block_t::lock and dict_index_t::lock.

      It would be tempting to use the lightweight wrapper mysql_rwlock_t, but unfortunately it would introduce a performance regression on Linux. On Microsoft Windows, we can use a straightforward wrapper of SRWLOCK. On Linux, a std::atomic<uint32_t> and a futex will do. On anything else, we can use mysql_rwlock_t.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24142 rw_lock_t has unnecessarily complex wait logic

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-24258 Merge dict_sys.mutex into dict_sys.latch

          • Major - Major loss of function.
          • Closed
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24884 Hang in ssux_lock_low::write_lock()

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24171 index_online_log is incorrectly instrumented as rw-lock, not mutex

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24271 rw_lock::read_lock_yield() may cause writer starvation

          • Major - Major loss of function.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-7109 Add support for INFORMATION_SCHEMA.INNODB_SEMAPHORE_WAITS

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-7399 Add support for INFORMATION_SCHEMA.INNODB_MUTEXES

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24410 Deadlock between freeing and allocating undo pages

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25267 Reported latching order violation in ibuf_remove_free_page()

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21330 Lock monitor doesn't print a semaphore's last reserved thread in non-debug builds and INFORMATION_SCHEMA.INNODB_SYS_SEMAPHORE_WAITS is totally broken

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24630 MY_RELAX_CPU assembly instruction upgrade/research for memory barrier on ARM

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. MDEV-32065 Always check whether lock is free at first to optimize InnoDB mutexes

          • Major - Major loss of function.
          • Open

          Activity

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.