Details
-
Bug
-
Status: Closed (View Workflow)
-
Blocker
-
Resolution: Fixed
-
10.0, 10.1, 10.2, 10.3, 10.4, 10.5
Description
The following test demonstrates that while InnoDB is collecting statistics are collected on a large table, any access from SQL to that table will be unnecessarily blocked by dict_table_stats_lock():
diff a/mysql-test/suite/innodb/t/stats_persistent.test b/mysql-test/suite/innodb/t/stats_persistent.test
|
new file mode 100644
|
--- /dev/null
|
+++ b/mysql-test/suite/innodb/t/stats_persistent.test
|
@@ -0,0 +1,26 @@
|
+--source include/have_innodb.inc
|
+--source include/have_debug.inc
|
+--source include/have_debug_sync.inc
|
+--source include/count_sessions.inc
|
+
|
+CREATE TABLE t1(a int) ENGINE=INNODB STATS_PERSISTENT=1;
|
+
|
+SET DEBUG_SYNC='dict_stats_update_persistent SIGNAL stop WAIT_FOR go';
|
+send ANALYZE TABLE t1;
|
+
|
+--connect(con1, localhost, root)
|
+SET DEBUG_SYNC='now WAIT_FOR stop';
|
+
|
+SELECT * FROM information_schema.TABLES WHERE ENGINE='InnoDB';
|
+
|
+SET DEBUG_SYNC='now SIGNAL go';
|
+--disconnect con1
|
+
|
+--connection default
|
+--reap
|
+SET DEBUG_SYNC= 'RESET';
|
+DROP TABLE t1;
|
+
|
+--source include/wait_until_count_sessions.inc
|
diff a/storage/innobase/dict/dict0stats.cc b/storage/innobase/dict/dict0stats.cc
|
--- a/storage/innobase/dict/dict0stats.cc
|
+++ b/storage/innobase/dict/dict0stats.cc
|
@@ -2207,6 +2207,8 @@ dict_stats_update_persistent(
|
|
dict_table_stats_lock(table, RW_X_LATCH);
|
|
+ DEBUG_SYNC_C("dict_stats_update_persistent");
|
+
|
/* analyze the clustered index first */
|
|
index = dict_table_get_first_index(table); |
We can allow multiple threads to collect statistics for the same table in parallel, but only one thread at a time may be allowed to update the statistics. To prevent unnecessary work for multiple threads collecting statistics for the same table, we might introduce a counter of pending statistics-gathering operations. MySQL 5.7.32 preferred to introduce a lazily initialized mutex, which would not be easy to merge to 10.4.
Attachments
Issue Links
- blocks
-
-
- Closed
-
- causes
-
-
- Closed
-