Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23196

Compression opts not enabled on user defined settings

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 10.2.25, 10.5.4
    • Fix Version/s: 10.3, 10.4, 10.5
    • Labels:
      None
    • Environment:
      mariadb.org binary distribution
      Ubuntu 18.04.3 LTS
      Ubuntu 19.10

      Description

      When setting compression_opts in rocksdb_default_cf_options, it is supposed to set the rocksdb internal setting Options.compression_opts.enabled to true. Checking the rocksdb LOG in MariaDB the value stays false, unless explicitly set to true.

      Not working sample conf: rocksdb_default_cf_options=...;compression_opts:-14:3:0;...

      Working sample conf: rocksdb_default_cf_options=...;compression_opts:-14:3:0:0:0:true;...

      This behavior seems not desired according to rocksdb's description of this parameter:
      // When the compression options are set by the user, it will be set to "true".
      // For bottommost_compression_opts, to enable it, user must set enabled=true.
      // Otherwise, bottommost compression will use compression_opts as default
      // compression options.
      //
      // For compression_opts, if compression_opts.enabled=false, it is still
      // used as compression options for compression process.
      //
      // Default: false.
      bool enabled;
      https://github.com/facebook/rocksdb/blob/master/include/rocksdb/advanced_options.h

      Not sure if this is supposed to be different in MyRocks than in RocksDB but my best guess is that it is not. My fear is that set compression options are not actually used.

        Attachments

          Activity

            People

            Assignee:
            psergei Sergei Petrunia
            Reporter:
            jkrauss Jonas Krauss
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:

                Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.