Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20044

Replace dynamic storage engine initialisation with declarative approach

    Details

    • Type: Task
    • Status: Stalled (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: 10.5
    • Component/s: Plugins
    • Labels:
      None

      Description

      Since we introduced a few incompatible SE API changes and we'll have to bump SE API version anyway, we could try implementing this in 10.5.

      Originally plugins were intended to use declarative approach, e.g. plugin/fulltext/plugin_example.c is an example of such approach. It fills in simple_parser_descriptor and passes it via plugin descriptor to the server.

      However SE API implements dynamic approach for no apparent reason. That is server (ha_initialize_handlerton()) allocates handlerton and then passes it to a plugin for further initialisation via plugin->init() call.

      We should attempt switching it to declarative approach, which means 1. extending st_mysql_storage_engine like:

      struct st_mysql_storage_engine
      {
        int interface_version;
        handlerton *hton;
      };
      

      or even

      struct st_mysql_storage_engine: public handlerton
      {
        st_mysql_storage_engine(...): handlerton(...) {}
        int interface_version;
      };
      

      2. removing hton argument from SE plugin->init(hton)

      3. making use of plugin_decl(plugin)->info->hton rather than hton

        Attachments

          Activity

            People

            • Assignee:
              robertbindar Robert Bindar
              Reporter:
              svoj Sergey Vojtovich
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: