Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15758

Split Item_bool_func::get_mm_leaf() into virtual methods in Field and Type_handler

    XMLWordPrintable

Details

    Description

      The code in Item_bool_func::get_mm_leaf() and stored_field_cmp_to_item() has tests for Field::type_handler(), Field::cmp_type(), Field::type().
      This is not friendly to pluggable data types.

      Under terms of this task we'll split the code into new virtual methods with approximately these prototypes:

      virtual SEL_ARG *Field::get_mm_leaf(RANGE_OPT_PARAM *param, KEY_PART *key_part,
      		 
                                          const Item_bool_func *cond,
      		 
                                          int op, Item *value);
      		 
      virtual int Type_handler::stored_field_cmp_to_item(THD *thd, Field *field, Item *item) const;

      and move data-type specific pieces of Item_bool_func::get_mm_leaf() and stored_field_cmp_to_item() into virtual implementations of the new methods.

      With this approach, pluggable data types will be able to implement their own methods to control the range optimizer

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13995 MAX(timestamp) returns a wrong result near DST change

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          New Feature - A new feature of the product, which has yet to be developed. MDEV-8787 Return Impossible WHERE instead of Full table scan on some admittedly false field=const expressions

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-15759 Expect "Impossible WHERE" for indexed_int_column=out_of_range_int_constant

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-16784 Range search does not work well for decimal_10_2_column<10.999

          • Major - Major loss of function.
          • Open

          Activity

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.