Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14517

Cleanup for Item::with_subselect and Item::has_subquery()

    XMLWordPrintable

Details

    Description

      There are two parallel implementations for the same thing - detection if an Item has a subquery, directly or recursively, e.g. via arguments etc.

      • A memmber Item::with_subselect, which is set in constructors and/or during fix_fields()
      • A virtual method Item::has_subquery()

      We'll remove Item::with_subselect and use the virtual implementation all around the code.

      Rationale:
      1. Get rid of duplicate functionality
      2 With virtual implementation it will be easier to follow:

      • which Item subclasses always have a subquery (e.g. Item_subselect)
      • which Item subclasses can have a subquery
      • which Item subclasses can never have a subquery

      Attachments

        Activity

          People

            bar Alexander Barkov
            bar Alexander Barkov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.