Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13963

storage/tokudb/PerconaFT/ft/serialize/ft-serialize.cc:419: suspicious switch statement ?

    XMLWordPrintable

Details

    Description

      Source code is

          switch (version) {
      		 
              case FT_LAYOUT_VERSION_29:
      		 
                  size += sizeof(uint64_t);  // logrows in ft
      		 
              case FT_LAYOUT_VERSION_28:
      		 
                  size += sizeof(uint32_t);  // fanout in ft
      		 
              case FT_LAYOUT_VERSION_27:
      		 
              case FT_LAYOUT_VERSION_26:

      Maybe some missing break statements here. Either that or some missing comments
      saying the fallthrough is deliberate.

      Attachments

        Activity

          People

            Unassigned Unassigned
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.