Uploaded image for project: 'MariaDB ColumnStore'
  1. MariaDB ColumnStore
  2. MCOL-4399

Replace the member charsetNumber in all classes to CHARSET_INFO*

    XMLWordPrintable

Details

    • Task
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • N/A
    • 23.10
    • ExeMgr, PrimProc
    • None

    Description

      Replace all class members charsetNumber to CHARSET_INFO pointer

      Many classes store character set and collation information in an integer member "charsetNumber".
      Some classes have two members:

      • uint32_t charsetNumber
      • CHARSET_INFO *charset

      The former is resolved occasionally from the latter using the get_charset() function.

      Let's remove all numberic members charsetNumber. We should always use CHARSET_INFO for the code simplicity.

      Conversion from a CHARSET_INFO pointer to a number should only happen in serialization.
      Resolving a number to a CHARSET_INFO pointer should only happen in deserialization.

      Attachments

        Activity

          People

            Unassigned Unassigned
            bar Alexander Barkov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.