Details
-
Bug
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Won't Fix
-
1.1.5
-
None
Description
sendMsgProcMon receives a string for module id and looks up an ip address from the config file then pings the ip address. If this check of the module fails currently it returns API_SUCCESS
if ( IPAddr == oam::UnassignedIpAddr ) { |
log.writeLog(__LINE__, "sendMsgProcMon ping failure " + module + " " + IPAddr, LOG_TYPE_ERROR); |
return oam::API_SUCCESS; |
}
|
|
string cmdLine = "ping "; |
string cmdOption = " -c 1 -w 5 >> /dev/null"; |
string cmd = cmdLine + IPAddr + cmdOption;
|
if ( system(cmd.c_str()) != 0) { |
//ping failure |
log.writeLog(__LINE__, "sendMsgProcMon ping failure " + module + " " + IPAddr, LOG_TYPE_ERROR); |
return oam::API_SUCCESS; |
}
|
Changing this could break in unknown places based on the return success not triggering the immediate failure of a module. So while changing this is simple could require significant testing to verify failures are handled properly